Open acjh opened 1 year ago
Fixes https://stackoverflow.com/questions/76509663/typeerror-joypadspace-reset-got-an-unexpected-keyword-argument-seed.
JoypadSpace doesn't correctly override the reset() method of Wrapper.
JoypadSpace
reset()
Wrapper
gym
**kwargs
Env
seed
Since nes-py now requires gym>=0.17.2, it is unnecessary to implement (override) reset() method.
gym>=0.17.2
Please select all relevant options:
Since nes-py now requires gym>=0.17.2, removing the method override is a non-breaking change.
Not tested yet (I'm not a nes-py user), but the fix is straightforward.
NIL.
Description
Fixes https://stackoverflow.com/questions/76509663/typeerror-joypadspace-reset-got-an-unexpected-keyword-argument-seed.
JoypadSpacedoesn't correctly override thereset()method ofWrapper.JoypadSpacereset()was implemented forgym0.10.5 in nes-py 0.8.7 (Jul 2018).Wrapperreset()was defined with**kwargsingym0.10.6 (Oct 2018).Though at the time
Envreset()did not accept any parameters.Envreset()started to acceptseedparameter ingym0.22.0 (Feb 2022).Since nes-py now requires
gym>=0.17.2, it is unnecessary to implement (override)reset()method.Type of change
Please select all relevant options:
Since nes-py now requires
gym>=0.17.2, removing the method override is a non-breaking change.How Has This Been Tested?
Not tested yet (I'm not a nes-py user), but the fix is straightforward.
Test Configuration
NIL.
Checklist