Kava-Labs / ilp-sdk

Stream Interledger payments between Lightning, Ethereum and XRP
Apache License 2.0
28 stars 13 forks source link

feat: add encrypted, multi-env configs #41

Closed kincaidoneil closed 5 years ago

kincaidoneil commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #41 into master will decrease coverage by 0.34%. The diff coverage is 87.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
- Coverage   90.23%   89.89%   -0.35%     
==========================================
  Files          16       16              
  Lines         635      653      +18     
  Branches       31       31              
==========================================
+ Hits          573      587      +14     
- Misses         52       56       +4     
  Partials       10       10
Impacted Files Coverage Δ
src/services/stream-server.ts 83.33% <ø> (ø) :arrow_up:
src/settlement/machinomy.ts 93.54% <0%> (-1.54%) :arrow_down:
src/settlement/xrp-paychan.ts 93.33% <0%> (-1.27%) :arrow_down:
src/settlement/lnd.ts 89.28% <0%> (-1.63%) :arrow_down:
src/index.ts 93.65% <93.33%> (+0.2%) :arrow_up:
src/config.ts 88.57% <95.23%> (+2.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 725fd97...05ca297. Read the comment docs.

kincaidoneil commented 5 years ago

Not sure the best way to test these:

karzak commented 5 years ago

Not sure the best way to test these:

  • Configs with multiple environments

Rather than setting up a local environment, could we connect to the testnet and mainnet connectors? We could use lightning on mainnet to avoid fees, or just create uplinks without depositing.