KaveIO / PhiK

Phi_K correlation analyzer library
Other
156 stars 28 forks source link

Ordering of column names in correlation matrix #1

Closed sbrugman closed 4 years ago

sbrugman commented 5 years ago

The df.phik_matrix() returns the correlation matrix with the column names ordered. Pandas keeps the order identical to the input (e.g. df.corr('pearson')).

I would propose to preserve the order as given in the dataframe. It is a simple preprocessing step to sort the columns if desired, for reversing we need to get the mapping from the original dataframe etc. This also allows for easier comparison with correlation matrices produces by pandas.

mbaak commented 5 years ago

Will take a look.

mbaak commented 4 years ago

Thanks for the big cleanup Simon! ;-)

I've pushed phik v0.10.0 to pypi