search

KaveIO / PhiK

Phi_K correlation analyzer library
Other
155 stars 28 forks source link

Update setup to make it compatible with --use-feature=in-tree-build #25

Closed RUrlus closed 3 years ago

RUrlus commented 3 years ago

Pip is switching to --use-feature=in-tree-build as default. The previous setup was not fully compatible with this. The extension (.so) is now also installed to phik/lib/

RUrlus commented 3 years ago

@mbaak Something very strange is happening with the integration tests. With the new setup the notebook integration test fails on the advanced notebook, indicating it has something to do with the extension. However, the unit test also calls sim_2d_patefield and that test passes.

If we use the new in-tree-build feature from pip, the exact same tests pass, see In-tree-build I can't replicate the failure locally, I tried with a clean venv and all the three install options (in-tree, out-of-tree and develop/-e) and the notebooks run without issue.

Can you give it a try locally?

Note that the sim_2d_patefield function was returning the transposed table, this is now fixed.

mbaak commented 3 years ago

Hi Ralph, usinng your updated branch, the units tests work for me locally. I'll use this to branch off from for my further updates.