search

KaveIO / PhiK

Phi_K correlation analyzer library
Other
155 stars 28 forks source link

Distance metric in UMAP #3

Closed gokceneraslan closed 4 years ago

gokceneraslan commented 4 years ago

It would be interesting to see PhiK as a distance metric in UMAP (see https://github.com/lmcinnes/umap/issues/319). However, it requires a concise numba-enabled implementation in distances.py

mbaak commented 4 years ago

In distances.py, you can add a 'phik' function that call the function below, which accepts to arrays as input: https://github.com/KaveIO/PhiK/blob/master/python/phik/phik.py#L233

mbaak commented 4 years ago

Thanks for the suggestion, but I'm afraid I don't have time to implement phi_k in umap's distances.py (however cool umap may be). They can use this library though! Will close this issue now.