KavrakiLab / robowflex

Making MoveIt Easy!
https://kavrakilab.github.io/robowflex/
Other
116 stars 24 forks source link

Fix range of function to be consistent with documentation #295

Closed ChamzasKonstantinos closed 2 years ago

ChamzasKonstantinos commented 2 years ago

Fixes #294

ChamzasKonstantinos commented 2 years ago

somethings wrong with dart? This is the error from the ci

Cannot add PPA: 'ppa:~dartsim/ubuntu/ppa'.
ERROR: '~dartsim' user or team does not exist.
ChamzasKonstantinos commented 2 years ago

somethings wrong with dart? This is the error from the ci

Cannot add PPA: 'ppa:~dartsim/ubuntu/ppa'.
ERROR: '~dartsim' user or team does not exist.

Seems it was a random failure, I rerun the ci and seems to build now

zkingston commented 2 years ago

Please update uniformSample and other places that uniformInt was used to respect the new API.

ChamzasKonstantinos commented 2 years ago

Good catch, I fixed uniformSample and verified its correct behavior with uniformVec which samples uniformly from a vector with the following syntax RNG::uniformVec(vec);