KavrakiLab / robowflex

Making MoveIt Easy!
https://kavrakilab.github.io/robowflex/
Other
114 stars 24 forks source link

Allow use of robowflex_dart with C++20 #315

Open wbthomason opened 1 year ago

wbthomason commented 1 year ago

This may be a controversial PR - it's meant to allow use of robowflex_dart with C++20 projects, and potentially outside of ROS/catkin contexts.

Currently, it does so by adding the ROBOWFLEX_DART_ONLY compile definition, and using this to gate the features in robowflex::darts::Robot that use parts of MoveIt that are incompatible with C++20. This suffices to allow C++20 projects that use only the rest of robowflex_dart to build.

However, this may be incomplete (i.e., there could be other parts of robowflex_dart that also need this gating applied), and it may not be the best way to achieve C++20 compatibility. I have also not tested this for building outside of catkin yet.

Thoughts?