Adding themes doesn't work anymore

[GoogleCodeExporter]

In particular, our test case (provided by Brian Deuel) should again
function to allow people to add themes, with appropriate disclaimers. I
have promised to fix this for 9.2 since it is frequently requested.

http://mozilla-themes.schellen.net/mozilla-theme-installation.html

Original issue reported on code.google.com by classi...@floodgap.com on 2 Mar 2010 at 5:01

[GoogleCodeExporter]

Actually, let's clarify the summary ...

Original comment by classi...@floodgap.com on 2 Mar 2010 at 5:01

• Changed title: Adding themes doesn't work anymore
• Added labels: Regression

[GoogleCodeExporter]

sakuya adds: 
> - If you don't have any windows open, switching the theme doesn't give you
> the alert about changes not taking effect until you restart the browser.
> This is also in 9.0.4.

Original comment by classi...@floodgap.com on 3 Mar 2010 at 4:15

[GoogleCodeExporter]

A breakpoint in 
xpinstall/nsJSInstallTriggerGlobal::InstallTriggerGlobalInstallChrome
gave us our answers. And actually, theming does work ... iff:

- themes.mozdev.org actually worked. As it stands, you can download them, but 
the
themeswitcher js is gone, so you have to switch stylesheets to see downloads 
from
View > Use Style.

- Software installation is enabled. Otherwise, it will silently fail.

I was able to install the Rain theme from mozdev (which is rather nice, in 
fact).
These bugs, other than what Sakuya mentioned, appear to me:

- Classilla should warn you if software installation is disabled rather than 
silently
failing.

- Classilla should warn you you need to restart the browser after installation. 
This
is easiest done on the box that has the checkbox for [ ] Use this theme

Maybe we should harvest some of the Classilla-compatible (i.e. Moz 1.3 and 
prior)
themes and put them somewhere for people to grab.

Original comment by classi...@floodgap.com on 24 May 2010 at 3:01

[GoogleCodeExporter]

Changes applied. Works as stated.

Original comment by classi...@floodgap.com on 24 May 2010 at 4:25

• Changed state: Fixed