search

KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

Don't let users delete personal toolbar folder #153

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Reported by Jens:

Hi.
I deleted my personal toolbar folder, and now I can't create a new one *that 
gets used* .
When deleting my profile and prefs, thus having to setup Classilla anew, 
everything is fine again.

We should add some code to rebless the personal folder, either automagically on 
creation or manually.

Original issue reported on code.google.com by classi...@floodgap.com on 9 Sep 2010 at 3:57

GoogleCodeExporter commented 9 years ago 
Unfortunately, like issue 128, we can't rebless it (in this case, we can 
manually do so by adding PERSONAL_TOOLBAR_FOLDER="true", but the browser isn't 
set up for this), so like that issue, we will simply prevent the user from 
deleting it.

Original comment by classi...@floodgap.com on 6 Feb 2011 at 11:52

GoogleCodeExporter commented 9 years ago 
Oddly, it looks like this code is *already* in personalToolbar.js, it just 
doesn't work.

Original comment by classi...@floodgap.com on 6 Feb 2011 at 11:55

GoogleCodeExporter commented 9 years ago 
That's because it had not been actually duplicated in bookmarks.xml. Added code 
to disable cut and delete in isCommandEnabled:

            if (this.mOuter.treeBuilder.getResourceAtIndex(this.mOuter.firstSelectedIndex).Value == "NC:PersonalToolbarFolder")
              return false; // Classilla issue 153

Now the options are no longer offered.

Original comment by classi...@floodgap.com on 7 Feb 2011 at 12:41