search

KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

Style context needs to be able to sweep sometimes (maybe manually?) #176

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Fallout from issue 165. We need to be able to sweep the context at some points, 
so we're back to determining when it is safe to do so. A potential workaround 
is to force a manual mark and sweep when Cmd-. is down, but runs the risk of 
causing a crash.

One possibility: don't mark unless Cmd-. is down, but always sweep. Another 
possibility: don't mark ourselves if we have no parent or dependent bits.

Original issue reported on code.google.com by classi...@floodgap.com on 2 Nov 2011 at 1:26

GoogleCodeExporter commented 9 years ago 
s/don't EVER mark ourselves/

Original comment by classi...@floodgap.com on 2 Nov 2011 at 1:26

GoogleCodeExporter commented 9 years ago 
Cameron Kaiser wrote:
> I need a test URL for this.
> 

It?s getting worse the more opened tabs there are. Open some standard 
tabs, and than go to http://sourceforge.net/projects/shadowirc/files/ as 
http://download.cnet.com/ShadowIRC/3000-2150_4-10016109.html
and you will see the effect I am talking about.

I can reproduce this at a G4 733MHz

Mathias

Original comment by classi...@floodgap.com on 3 Nov 2011 at 4:48

GoogleCodeExporter commented 9 years ago 
Restored bug 117316 as written, but with one change: we don't use the 
SweepRuleNodeChildren hash operator, because I had always suspected it didn't 
work (PL_DHASH_NEXT is 0 in 1.3.1). Instead, we manually walk the tree. This is 
so far okay.

Original comment by classi...@floodgap.com on 6 Nov 2011 at 2:57

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 6 Nov 2011 at 2:58

GoogleCodeExporter commented 9 years ago 
Still getting crashes now and then.

Original comment by classi...@floodgap.com on 3 Jan 2012 at 3:42

GoogleCodeExporter commented 9 years ago 
Maybe we can do this based on number of sweeps done. If it gets over some 
critical number that we skipped, force a sweep and pray.

Original comment by classi...@floodgap.com on 9 Jan 2012 at 3:55

GoogleCodeExporter commented 9 years ago 
Modified with lots of safety checks in nsRuleNode. So far no crashes, but this 
is so intermittent it's hard to say.

Original comment by classi...@floodgap.com on 12 Jan 2012 at 2:59

GoogleCodeExporter commented 9 years ago

Original comment by classi...@floodgap.com on 12 Jan 2012 at 3:34

GoogleCodeExporter commented 9 years ago 
Further issues to go in new bug. I have not received a crash related to this 
bug since the 5th.

Original comment by classi...@floodgap.com on 20 Jan 2012 at 10:06