search

KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

nsImageLoader topcrash [addons.mozilla.org] #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Spun off from issue 24, reported from Report-A-Bug!. Nasty top crash.

Current candidates for fixes: 196797 + 199021

Original issue reported on code.google.com by classi...@floodgap.com on 22 Aug 2009 at 10:36

GoogleCodeExporter commented 9 years ago 
nsImageLoader::OnStartContainer base/src/nsImageLoader.cpp
imgRequestProxy::OnStartContainer modules/libpr0n/src/imgRequestProxy.cpp
imgRequest::OnStartContainer modules/libpr0n/src/imgRequest.cpp
nsJPEGDecoder::WriteFrom modules/libpr0n/decoders/jpg/nsJPEGDecoder.cpp
imgRequest::OnDataAvailable modules/libpr0n/src/imgRequest.cpp
ProxyListener::OnDataAvailable modules/libpr0n/src/imgLoader.cpp

Original comment by classi...@floodgap.com on 4 Sep 2009 at 3:40

GoogleCodeExporter commented 9 years ago 
Does not crash in Mozilla 1.7.

Original comment by classi...@floodgap.com on 4 Sep 2009 at 3:47

GoogleCodeExporter commented 9 years ago 
Code looks roughly similar. Adding guard code from 293986.

Original comment by classi...@floodgap.com on 4 Sep 2009 at 3:59

GoogleCodeExporter commented 9 years ago 
I'm not sure if 293986 made any difference (+ backbugs), but it's good to have. 
The
actual fix turned out to be checking for a null mPresContext in layout 
nsImageLoader.
The page now loads, so back to layout.

Original comment by classi...@floodgap.com on 4 Sep 2009 at 4:12