search

KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

Hash/anchor tag navigational issues #54

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Various navigational failures now that DOM Level 3 support is improved. In
particular, Google sees us as a Firefox client now, so it tries to use its
fragment based navigation, which currently fails.

Candidates:
https://bugzilla.mozilla.org/show_bug.cgi?id=205989

We should also try to pull up SetHash and SetHref to 1.8.
http://mxr.mozilla.org/mozilla1.8/source/dom/src/base/nsLocation.cpp?raw=1

Original issue reported on code.google.com by classi...@floodgap.com on 28 Aug 2009 at 6:14

GoogleCodeExporter commented 9 years ago 
205989 does not look like our bug.

233963 did not appear to fix the problem.

new candidates (I'm tired, man): 273158 (regression fix in 465263)

Original comment by classi...@floodgap.com on 2 Sep 2009 at 5:32

GoogleCodeExporter commented 9 years ago 
Also, pulling up nsLocation to 1.8.1 introduced some changes to 
nsGlobalWindow.h I
don't want to do if I don't have to.

Original comment by classi...@floodgap.com on 2 Sep 2009 at 5:33

GoogleCodeExporter commented 9 years ago 
273158 is superseded by 280215

Original comment by classi...@floodgap.com on 4 Sep 2009 at 4:28

GoogleCodeExporter commented 9 years ago 
Tangentially related, landed 198660 since it fixes a regression from 92773 which
might cause trouble for this later on.
Trying to land 277224 + 297122 next (this supersedes 233963).

Original comment by classi...@floodgap.com on 4 Sep 2009 at 5:08

GoogleCodeExporter commented 9 years ago 
In fact landing 277224 + 297122 pretty much pulls us up to 1.8.1 anyway, with 
the
same nsGlobalWindow changes and a few IDL updates, so that was the right move.

Original comment by classi...@floodgap.com on 4 Sep 2009 at 5:34

GoogleCodeExporter commented 9 years ago 
Finally closing this bug up. Updating summary. The following was done to close 
this
issue out:

pull up of more code to 1.8.1, look through the code base if you like
XUL bindings updated: M104778 M231393 M302575 M306810 with pullups
then M130265/m M205817 M205989
then M249322 (Mozilla path only) security note
then M237566/p
then a line of kludge code into ScrollIfAnchor so that a bogus anchor still 
returned
NS_OK, not NS_ERROR_FAILURE, since this prevented OnLocationChange from being 
fired. 
Essentially this is quirks mode logic being used for both standard and quirks, 
but
works 100% with Google, which thinks we are a fully compatible Firefox 3, along 
with
my internal test case.

FIXED

Original comment by classi...@floodgap.com on 10 Sep 2009 at 5:29