Open Location should open a window if one is not open

[GoogleCodeExporter]

An annoyance.

Original issue reported on code.google.com by classi...@floodgap.com on 5 Nov 2009 at 5:58

[GoogleCodeExporter]

1.  If you use Open Web Location (Command-Shift-L), and have 'Open in: Current 
Navigator window' selected, and there is no window currently open, it will just 
do nothing.  In that case, it should create a new window anyway.
Likewise if you select 'Open in: New Navigator tab' when there's no current wind
ow.

Original comment by classi...@floodgap.com on 5 Nov 2009 at 5:59

[GoogleCodeExporter]

Accepting for 9.1

Original comment by classi...@floodgap.com on 25 Feb 2010 at 1:42

• Added labels: Milestone-Release9.1

[GoogleCodeExporter]

If current window is selected, and there is no current window, it should just 
fall
through to new window.

Original comment by classi...@floodgap.com on 26 Feb 2010 at 6:40

[GoogleCodeExporter]

Dropping for 9.1, here's why.

This bug actually has two issues in it, only one of which I am comfortable 
tweaking
this close to 9.1. The first bug is that openLocation.js doesn't check 
window.closed
to see if it has a real, useable browser window; I modified M528732 for this 
purpose.

The bigger problem, though, is that window.closed doesn't work. While it looks 
like
it should, according to the way I read dom::nsGlobalWindow.cpp (if there is no
docshell, return true in nsGlobalWindow::GetClosed() ), in practice the docshell
seems to be getting burned out late or not at all and the window still appears 
valid
when openLocation.js asks the window mediator for the most recent browser. This 
is a
lower-level change than I am comfortable making this time around, so I am 
dropping
the milestone for right now.

Original comment by classi...@floodgap.com on 26 Feb 2010 at 8:13

• Removed labels: Milestone-Release9.1

[GoogleCodeExporter]

While working on last-closed-tab today I had a brainwave about this. Since we 
know in navigator.js whether we have a browser content object or not (i.e., 
getBrowser()), we can pass that to the openLocation.xul window. If it's null, 
then we force a new window to open. And that works. VERIFIED

Original comment by classi...@floodgap.com on 13 Aug 2010 at 9:33

• Changed state: Verified