search

KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

Textboxes that stretch crash browser #93

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In the overflow branch-enabled 9.1, stretching a textbox causes the browser
to crash. M234761 seems the most likely fix but this patch will not apply
as is as they are getting an nsIContent we don't pass (in order to do the
IsNativeAnonymous() test).

Original issue reported on code.google.com by classi...@floodgap.com on 22 Jan 2010 at 5:50

GoogleCodeExporter commented 9 years ago 
This was not fixed by M234761, although that patch does fix its particular bug. 
Code
added to pass in the nsIContent (which is simply "this") in two places.

The problem came down to
layout/html/forms/gfx/nsTextControlFrame.cpp::CreateAnonymousContent. Although 
we
were correctly setting native anonymous thanks to M234761, the code from M69355
(which is in 9.1-current but not 9.0.4 or 9.0) was only adding attributes for
overflow if the style display type was NOT _AUTO, _VISIBLE or _CLIP (and then 
it was
always overflow:inherit). However, the original code always added something, 
even if
nothing was specified, and the fallback was overflow:auto.

The consensus code specifies _SCROLL and _HIDDEN with :scroll and :hidden 
explicitly,
specifies :auto for _AUTO, _VISIBLE or no overflow property at all, and then 
:inherit
for everything else.

Although this seems to cover all the bases, this really shouldn't have 
happened, so I
am logging this fix as a KLUDGE.

VERIFIED

Original comment by classi...@floodgap.com on 26 Jan 2010 at 12:00