KawaiiBASIC / classilla

Automatically exported from code.google.com/p/classilla
0 stars 0 forks source link

Factor CalcWindowRegions() out of StartDraw() in widget.shlb #99

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In the Widget shlb, CalcWindowRegions() is an expensive function to call.
Although I have backed out part of M162885, which improves this a bit by
replacing ::CopyRgn with a less fatty ::OffsetRgn, it seems to me that
StartDraw() should not be calling it every time StartDraw() is called.
Instead, we should make those routines call CWR() if they really, REALLY
need to themselves. If we can factor it out of even just a couple places
this would be a big performance win, and we really need it with the
overflow overhead in 9.1-current, so marking High.

Original issue reported on code.google.com by classi...@floodgap.com on 26 Jan 2010 at 6:21

GoogleCodeExporter commented 9 years ago
Actually, marking Critical. We really need some perf power to get 9.1 off the 
ground.

Essentially we will take CWR() out of StartDraw(), then start adding it back 
into the
individual calls for widgets that don't paint right.

Original comment by classi...@floodgap.com on 26 Jan 2010 at 6:23

GoogleCodeExporter commented 9 years ago
This is done, but it didn't make a great deal of difference unfortunately.

Original comment by classi...@floodgap.com on 29 Jan 2010 at 9:45