search

Kawasaki-Robotics / khi_robot

ROS KHI robot meta-package
http://wiki.ros.org/khi_robot
BSD 3-Clause "New" or "Revised" License
55 stars 28 forks source link

Prefix all pkgs with 'khi_' #10

Closed d-nakamichi closed 5 years ago

d-nakamichi commented 5 years ago

This PR converts all of packages to khi_* for #4 It changes only package(directory) names.

d-nakamichi commented 5 years ago

I rebased on master to solve a conflict.

@matsui-hiro I think master currently has a problem about https://github.com/Kawasaki-Robotics/khi_robot/pull/8#issuecomment-479585050 Please consider to fix it.

gavanderhoorn commented 5 years ago

@d-nakamichi wrote:

It changes only package(directory) names.

the PR seems to change more than just the directory names, correct?

I would also expect there to be more changes needed.

d-nakamichi commented 5 years ago

@gavanderhoorn

the PR seems to change more than just the directory names, correct?

Is that means it changes codes of package references like this, right? It changes package(directory) names and those referenced codes. may be correct.

I would also expect there to be more changes needed.

I've already check it OK to build and execute moveit demo, although I'm concerned about https://github.com/Kawasaki-Robotics/khi_robot/pull/8#issuecomment-479585050 (this is about urdf/srdf robot name) What the expected changes, for example?

gavanderhoorn commented 5 years ago

All references to the old package names would need to be replaced with the new names.

I've already check it OK to build and execute moveit demo, although I'm concerned about #8 (comment) (this is about urdf/srdf robot name)

For MoveIt configurations, it may be easier to just recreate them (as they're mostly auto-generated anyway by the Setup Assistant).

For the rest of the packages: if you've compile tested this (and Travis has done that as well) and tested the launch files things should be fine.

We might want to add more roslaunch tests to automatically test whether roslaunch can still find all the packages, just as I did in #5.

d-nakamichi commented 5 years ago

OK. I changed launch files in khi_*_moveit_config/ based on MoveIt! Setup Assistant. I also added test files which launch moveit applications. Thank you.