Kawasaki-Robotics / khi_robot

ROS KHI robot meta-package
http://wiki.ros.org/khi_robot
BSD 3-Clause "New" or "Revised" License
55 stars 28 forks source link

Enable to build release package on i386/arm #19

Closed k-okada closed 5 years ago

k-okada commented 5 years ago
k-okada commented 5 years ago

yes, running arm vm is slow compared to the native architecture and I think we should add "--skip-test" option to 'generate_prerelease_script ' in future.

-- ◉ Kei Okada

2019年5月29日(水) 10:41 Daisuke NAKAMICHI notifications@github.com:

@d-nakamichi commented on this pull request.

In .travis.yml https://github.com/Kawasaki-Robotics/khi_robot/pull/19#discussion_r288364375 :

@@ -36,6 +41,8 @@ install:

  • cp -R $TRAVIS_BUILD_DIR $JOB_PATH/catkin_workspace/src/

    generate the script to run a pre-release job for that target and repo

  • generate_prerelease_script.py https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml $ROS_DISTRO_NAME default $OS_NAME $OS_CODE_NAME $ARCH --output-dir $JOB_PATH
  • skip build and test for ARM containers

    • if [[ "$ARCH" == "arm"* ]]; then sed -i '/build and test/i mkdir -p $WORKSPACE/catkin_workspace/test_results; exit 0' $JOB_PATH/prerelease_build_underlay.sh; fi

What is the reason adding this? Is it for timeout of travis?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Kawasaki-Robotics/khi_robot/pull/19?email_source=notifications&email_token=AADYNXF5YAWEYCT63REO6JDPXXNL7A5CNFSM4HOGKSYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZ57G5A#pullrequestreview-243004276, or mute the thread https://github.com/notifications/unsubscribe-auth/AADYNXBMGBLSQ7JCSWS3BSDPXXNL7ANCNFSM4HOGKSYA .

d-nakamichi commented 5 years ago

Thank you! @k-okada