search

Kawasaki-Robotics / khi_robot

ROS KHI robot meta-package
http://wiki.ros.org/khi_robot
BSD 3-Clause "New" or "Revised" License
55 stars 28 forks source link

Suggestion: prefix all pkgs with 'khi_' (REP-144 compliance) #4

Closed gavanderhoorn closed 5 years ago

gavanderhoorn commented 5 years ago

Some packages already have this prefix (such as khi_robot_control), but the suggestion is to prefix all packages in this repository with khi_ (so rs_description becomes: khi_rs_description, duaro_description becomes khi_duaro_description, etc).

There are two main motivations for doing this:

  1. avoid name clashes: prefixing with khi_ reduces the chance of a(n unrelated) package with the exact same name to near zero (ROS package names exist in a single, flat shared namespace and name clashes do happen)
  2. package provenance is immediately clear: the khi_ prefix uniquely identifies these packages are coming from Kawasaki Heavy Industries

Edit: an alternative prefix to consider could be kawasaki_ but that may be too generic and khi_ is already used.

gavanderhoorn commented 5 years ago

It would also make these packages more compliant with REP-144: ROS Package Naming (specifically: Naming Rules).

d-nakamichi commented 5 years ago

OK, we'll take the suggestion: khi_ prefix.

gavanderhoorn commented 5 years ago

This would seem to be addressed with the merge of #10.