Kaydax / Ido

Brings 1.13 and 1.14 movement like swimming and crawling into 1.12.2! Based off https://github.com/pentantan/BetterSwiming
Other
18 stars 4 forks source link

[Sticky] Known issues list #2

Open Kaydax opened 5 years ago

Kaydax commented 5 years ago

Here are all the known issues:

Multiplayer:

Singleplayer:

No issues currently exist for just singleplayer

Both:

Johni0702 commented 5 years ago

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

You're using mc's renderViewEntity instead of the player from the event (for some or possibly no reason): https://github.com/Kaydax/Ido/blob/cc2af3b988ec2b02b696567cbbecac506e0651ed/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L49-L53

Kaydax commented 5 years ago

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

You're using mc's renderViewEntity instead of the player from the event (for some or possibly no reason): https://github.com/Kaydax/Ido/blob/cc2af3b988ec2b02b696567cbbecac506e0651ed/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L49-L53

You just helped out a lot, thanks!

yezhiyi9670 commented 4 years ago

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

      // Minecraft.getMinecraft().getRenderViewEntity()
      if (event.getEntity() instanceof AbstractClientPlayer)
      {
        AbstractClientPlayer client = ((AbstractClientPlayer) event.getEntity());
        type = client.getSkinType().equals("slim");
      }

Maybe checking type like this can fix the issue (not tested).

yezhiyi9670 commented 4 years ago

Closing yourself inside of a door or fence gate will cause the player to start crawling

Checking if the action of "Start crawling" is no use before making the player crawl. However a player should be allowed to continue crawling of sneaking if it is stuck in a block.

EDIT: I went to see mechanics about this in 1.14. The player will not start crawling if the player will still be colliding with a block after beginning to crawl. When the player is already stuck in a block and will still be colliding with a block after beginning to sneak, the player will not sneak automatically, and will not be allowed to start sneaking as well. If a player close itself inside a door while sneaking and release the sneak key, the player will not stand up but its speed will be unaffected.

kappa-maintainer commented 4 years ago

I'm working on a mod using RenderPlayer class to change players' models, and I noticed my mod's poor compatibility with Ido. I suggest to use forge's capability system to implement a Ido switch on player, so other mods can simply disable Ido's function on certain players when conflicts happen.