search

Kaydax / Ido

Brings 1.13 and 1.14 movement like swimming and crawling into 1.12.2! Based off https://github.com/pentantan/BetterSwiming
Other
18 stars 3 forks source link

Can't swim in modded water #30

Closed floral-qua-floral closed 5 years ago

floral-qua-floral commented 5 years ago

Players can only swim in the vanilla water blocks. When mods such as ColorfulWater or Streams are added, which implement water-like blocks, Ido does not detect them and so the player can't use 1.13-style swimming in these liquids. For Streams in particular, since it replaces all rivers with its own water tiles, this hurts Ido's functionality quite a bit as you can no longer use the new swimming mechanic in natural rivers.

A proposed fix is to use some sort of dynamic system to detect water-like liquids rather than just supporting vanilla's water tiles. This would allow mods like ColorfulWater and Streams to work as expected without requiring explicit support to be added, as well as any other mods that add fluids similar to water. Alternatively, swimming could be allowed inside any fluid, which may be simpler.

I'd appreciate if this issue could be looked into so that I can appreciate the full benefits of this mod and Streams together. I feel like they'd work brilliantly alongside each other if only Ido could recognize Streams's moving water tiles.

Kaydax commented 5 years ago

It has already been added into the mod. Just build it from source and it should work fine

floral-qua-floral commented 5 years ago

Are there plans to put this update on CurseForge? I've been trying for quite a while to compile it from the source, but for some reason it's just not finding my JDK installation, it's getting to be a bit of a headache sorting this out - plus, I'd imagine there could be other people who'd love to see this fixed who aren't following the Github page. Either way, thanks for the response, loving the mod.

Edit- got it working after some more hassle. Point still stands about CurseForge though, seems like it'd still be a good idea to put it up there if the current build is stable imo. But I'm not the author here, so your call.