search

Kaydax / Ido

Brings 1.13 and 1.14 movement like swimming and crawling into 1.12.2! Based off https://github.com/pentantan/BetterSwiming
Other
18 stars 3 forks source link

Ido overrides other mods' changes to view heights, even when relevant parts of Ido are disabled #43

Open floral-qua-floral opened 4 years ago

floral-qua-floral commented 4 years ago

I'm testing this using the Custom Playermodel mod, however I assume any mod that changes bounding boxes or view heights will have the same interaction.

When Ido is installed, CPM models will not be able to change the player's eye heights at all. This issue persists even when all of Ido's config options are disabled. While compatibility can't be expected between the sneaking tweaks made by Ido and the sneaking tweaks available using CPM, it'd be ideal if disabling Ido's tweaks would allow CPM's to take effect. My assumption is that the issue is that Ido does not truly disable the sneak changes when that option is set to false, but instead just uses vanilla heights, and so it continues to prevent other mods from taking effect.

A very simple CustomPlayerModel file is included to indicate the issue. It is just a normal Steve model modified such that the hitbox and eye height should be much lower than normal when crouching. steveSmallSneak.zip

DoomRater commented 4 years ago

When using ArtemisLib, which allows the player to become differently sized using commands with Gulliver Reborn or potions using Resizing Potion, the viewpoint of the player is always the same regardless of player size. In addition, the model becomes very squished when swimming and fails to resize at all.