KayelGee / control-concealer

MIT License
1 stars 1 forks source link

Change Justification for the Tabs #10

Closed Baxmann closed 2 years ago

Baxmann commented 2 years ago

This is a nitpick but is extremely easy to implement. I noticed that the Module Simultaneous Combat System modifies the Tabs to Remove the default Combat Tracker. I no longer use that module, but the justification technique they used does improve the visuals after removing elements.

By default, the CSS of .tabs has "justify-content: flex-start;" as the value. BUT, it would be better off using "justify-content: space-between;". By doing that, the Tab Icons always have even spacing between them, instead of having void space between at the end of the line. Having Space-Between image In Edit Mode with Space-Between image Having Flex-Start :( image

KayelGee commented 2 years ago

I'll be honest I feel like this is out of the scope of this module. I'd rather see this change as a seperate module instead of forcing this on everyone using control concealer.

Baxmann commented 2 years ago

I'll be honest I feel like this is out of the scope of this module. I'd rather see this change as a seperate module instead of forcing this on everyone using control concealer.

I still believe that the void space created by removing buttons, which is the point of the module, should be considered a Bug.

But, I have found a workaround. There is a Module called Custom CSS Rules, which allows for me to modify it myself. For anyone else who'd like to keep it Space-Between, insert in as:

/ Custom CSS /

.tabs { justify-content: space-between; }

KayelGee commented 2 years ago

How the tabs are rendered is defined by foundries css, so I would say this is the default intended behaviour. Control concealer is just reducing the amount of visible tabs. There are modules that change how the ui looks. If I add additional css rules that makes it harder for those modules to work together with control concealer.

This is also a subjective thing. You like how it looks with even spacing but someone else might not. Using Custom CSS Rules is a better fit to do that.

Baxmann commented 2 years ago

So why not make it a Toggleable Option?