KayelGee / control-concealer

MIT License
1 stars 1 forks source link

Buttons for switching are misplaced #14

Closed remiverdel closed 2 years ago

remiverdel commented 2 years ago

Hi,

On my screen with no other module active, the D, P and Edit buttons are completely misplaced preventing access.

I'm using the latest version of the module on V9

Here is a screen shot

Capture d’écran 2022-03-09 à 17 05 01
KayelGee commented 2 years ago

Do you have any other modules active?

remiverdel commented 2 years ago

Hi,

No other module active on my end

Rémi Verdel

Le 9 mars 2022 à 18:02, KayelGee @.***> a écrit :

 Do you have any other modules active?

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.

KayelGee commented 2 years ago

oh yeah I just noticed myself sorry...

KayelGee commented 2 years ago

Which browser is this?

remiverdel commented 2 years ago

I’m using Google Chrome

Le 9 mars 2022 à 18:05, KayelGee @.***> a écrit :

Which browser is this?

— Reply to this email directly, view it on GitHub https://github.com/KayelGee/control-concealer/issues/14#issuecomment-1063152748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOV5535FEIQKI2R5B6TCE3U7DK47ANCNFSM5QJ7SXCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

KayelGee commented 2 years ago

Are you on a high dpi screen by any chance?

remiverdel commented 2 years ago

Yes I’m on a 4K screen

Le 10 mars 2022 à 17:21, KayelGee @.***> a écrit :

Are you on a high dpi screen by any chance?

— Reply to this email directly, view it on GitHub https://github.com/KayelGee/control-concealer/issues/14#issuecomment-1064247092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOV555VBQ6SZJ2EJOTEESDU7IOR7ANCNFSM5QJ7SXCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

KayelGee commented 2 years ago

Can you go into the devloper tools and select the <li class="control-concealer-top"> element so the style is shown on the right like on the following screenshot and make a screenshot how it looks on your end? image

remiverdel commented 2 years ago

Here it is. I reactivated all my modules for the screenshot as the result is the same with or without

Le 10 mars 2022 à 17:26, KayelGee @.***> a écrit :

Can you go into the devloper tools and select the

  • element so the style is shown on the right like on the following screenshot and make a screenshot how it looks on your end? https://user-images.githubusercontent.com/20637397/157708483-96bb88f3-ee40-4679-bb23-8a9b793832f3.png — Reply to this email directly, view it on GitHub https://github.com/KayelGee/control-concealer/issues/14#issuecomment-1064253571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOV55ZAK46JVUHCWN7AZTDU7IPFDANCNFSM5QJ7SXCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.

  • KayelGee commented 2 years ago

    I don't see anything. You probably need to attach the image directly in github

    remiverdel commented 2 years ago

    My bad, here it is.

    46855D3F-082A-4A19-88FC-00CEE1D01CF9
    KayelGee commented 2 years ago

    ok so your style.css is missing the whole "#controls ol.control-tools > li" part. Either your browser cached the style.css from a previous version of foundry or you manually edited(or it didn't update correctly) the style.css in FoundryVTT\resources\app\public\css.

    I'd suggest you clear the cache or check if your style.css is correct in your install. Line 2470 should look like this:

    #controls ol.control-tools > li {
      flex: none;
      width: 36px;
      height: 36px;
      margin: 0 0 10px 0;
      box-sizing: content-box;
      font-size: 24px;
      line-height: 36px;
      background: rgba(0, 0, 0, 0.5);
      box-shadow: 0 0 10px var(--color-shadow-dark);
      color: var(--color-text-light-heading);
      text-align: center;
      border: 1px solid var(--color-border-dark);
      border-radius: 5px;
      cursor: pointer;
      pointer-events: all;
      display: inline-block;
      /* Toggled Buttons */
    }
    remiverdel commented 2 years ago

    Thx strangely we didn’t have that in the style.css. We added it and it still didn’t work. We just updated to the last Foundry build and everything works fine now.

    Thx!

    Le 12 mars 2022 à 14:19, KayelGee @.***> a écrit :

    ok so your style.css is missing the whole "#controls ol.control-tools > li" part. Either your browser cached the style.css from a previous version of foundry or you manually edited(or it didn't update correctly) the style.css in FoundryVTT\resources\app\public\css.

    I'd suggest you clear the cache or check if your style.css is correct in your install. Line 2470 should look like this:

    controls ol.control-tools > li {

    flex: none; width: 36px; height: 36px; margin: 0 0 10px 0; box-sizing: content-box; font-size: 24px; line-height: 36px; background: rgba(0, 0, 0, 0.5); box-shadow: 0 0 10px var(--color-shadow-dark); color: var(--color-text-light-heading); text-align: center; border: 1px solid var(--color-border-dark); border-radius: 5px; cursor: pointer; pointer-events: all; display: inline-block; / Toggled Buttons / } — Reply to this email directly, view it on GitHub https://github.com/KayelGee/control-concealer/issues/14#issuecomment-1065882331, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOV5525EH2EMOH2P2RVTELU7SKVFANCNFSM5QJ7SXCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.