search

KayelGee / control-concealer

MIT License
1 stars 1 forks source link

The module does not work with Combat Carousel activated. #16

Closed Padhiver closed 2 years ago

Padhiver commented 2 years ago

Hi! I wanted to test your great module, starting to have a few too many non-deactivatable tools, but it turns out that it seems to be incompatible with Combat Carrousel. I used Find the Culprit to find out why I couldn't save changes to the module, and it seems that with Combat Carousel enabled, your module just doesn't work anymore.

Edit : All latest version of Foundry, Combat Caroussel, Control Concealer ... And Dnd5e.

image

Thank you !

Fyrexian commented 2 years ago

I've been hoping this would be fixed for so long now.. Both of these are really great modules...

kinland commented 2 years ago

The fix for this was unbelievably simple. Wish I'd taken a look sooner. You can temporarily install from my repo if you want it sooner. I didn't bump the version number in case @KayelGee's system does that automatically when generating a release.

KayelGee commented 2 years ago

appreciate the PR @dhorkin I'll check it on monday

matheusferreira commented 2 years ago

waiting the revision about this. I found your module today and is a feature that I didn't know that I need when I dm using notebook (hiding ui for local gaming session). But I use Combat Carousel too.

KayelGee commented 2 years ago

Sorry for taking so long, covid actually knocked me out the week I wanted to look at @dhorkin PR. I'll push out the new version today with the fix.