search

KayelGee / select-tool-everywhere

MIT License
3 stars 12 forks source link

Module breaks template snapping for hex grids. #3

Open rpilcrow opened 2 years ago

rpilcrow commented 2 years ago

After finding out that templates weren't snapping to the centre of grid cells correctly in my Lancer world, I decided to load up a clean world and test modules one-by-one. For some reason this module causes incorrect hex snapping behaviour. It looks like it's trying to apply a slightly offset square grid to the hex grid. This applies to all the hex grid types.

KayelGee commented 2 years ago

I always thought this was a core issue... thanks for pointing it out. After a quick check in foundry.js the issue is caused by a weird check that I'm not sure why it exists: foundry.js line 19423 return this.options.controllableObjects ? 2 : 5. For now you can edit your foundry.js and change the 2 to a 5 and it'll work again. I'm not sure about other consequences this might have so I'll have to see if I'll overwrite this in the future.

patrickburk1988 commented 2 years ago

This bug also seems to apply to other grid-based snappable objects like ambient sounds, light sources, etc.

The description for Better Hexagonal Tiles mentions that Foundry's hex renderer is wonky about snapping to the top-left of the grid. That module is intended for tiles, but if this bug is caused by the same issue, could the author's solution be adapted for other snappable objects?