search

KayelGee / token-attacher

MIT License
11 stars 18 forks source link

Using waypoints for token movement(this includes Drag Ruler) causes root token to teleport #35

Closed Sravdar closed 3 years ago

Sravdar commented 3 years ago

When both modules are active and something attached to token, root token moves in double speed and goes twice the way it should normally go (by cliping through walls etc) and then teleports back to place where it normally should be.

Weirdly if you press and hold "ALT" before you drop the token than it just moves in normal animaiton.

iotech-fvtt commented 3 years ago

Confirmed. I'm having an issue with Drag Ruler and Token Attacher on 0.8.8 self hosted. Player or GM, example: Move any token from A to B distance X in direction Y= on drag release, token draws at B, then moves in direction Y for X distance, passing through walls and providing vision, then snaps back to B.

Confirmed normal operation with either Drag Ruler or Token Attacher disabled, but with both enabled, the above behavior is observed.

KayelGee commented 3 years ago

I haven't played around with drag ruler yet but I'll check if this is fixable the next time I'm at the code

KayelGee commented 3 years ago

So I looked into the issue and this is not caused by the Drag Ruler module. This already happens when you use the core foundry waypoints to move your token. The reason this happens is because I update some value when the token get's moved and the animation system updates it's start position when any update happens, so it adjusts the animation which causes the teleportation. I'll probably report this as a core bug, because the animation shouldn't need to adjust itself, because I'm not updating any position data.

For now I'll leave this open. As a temporary solution you can deactivate token animation, if you don't want the movement to teleport through walls.

KayelGee commented 3 years ago

Nevermind turns out it was a bug on my end because of a misunderstanding. Will be fixed in the next update.

Hydrologist commented 2 years ago

This bug is occurring again when version 4.2.0 of this module is used together with DnD5e Helpers version 3.0.2. It specifically occurs when the "Enable Combat Action Management" setting in DnD5e Helpers is set to anything other than Disabled. I'm running Foundry version 0.8.9 on a dedicated server.

Given that you've fixed this for other cases and this only happens when used with this particular setting, I imagine this interaction may be on DnD5e Helpers' side, but I thought I'd let you know in case you have the bandwidth to look at it.