KayelGee / token-attacher

MIT License
11 stars 18 forks source link

4.5.13 can be downloaded by v10 despite incompatibility #99

Closed GambetTV closed 1 year ago

GambetTV commented 1 year ago

Just so you know, I hit the Update All button, and even though it shouldn't be possible, your module updated despite not being compatible with v10. It then wouldn't show up for me in my module list, until I manually deleted it and downgraded.

KayelGee commented 1 year ago

Did you install the module manually via manifest or did you install it directly via foundrys module manager?

GambetTV commented 1 year ago

Which time? If you mean the original time I downloaded it, I have no idea. I've used this module for a long, long time, so I can't remember how I originally installed it. That said I almost always just install it through Foundry using the search function rather than manually pasting a manifest link or downloading the file manually.

If you mean when I downgraded last night, I did that manually.

KayelGee commented 1 year ago

I meant originally. I've checked the manifest from 4.5.13, but it looks alright. It has a minimum version of 11. I've also checked the package in foundry and it also has a minimum version of 11.

I've had made a mistake at release #98 where the manifest pointed to the wrong version, maybe when you updated while this was wrong it might've caused this issue. But I don't know.

GambetTV commented 1 year ago

Okay, no worries! I think I didn't update any of my modules for about a month after v11's release, so maybe I just got caught out with that one. No biggy, just wanted to let you know!