KaylebJay / tunnelers-bugz

No code. Bug tracker for the Tunnelers' Abyss Minetest Server. Please report all bugs here or at our Discord in channel #dev.
4 stars 3 forks source link

The xdecor pressure plates disappeard ! #190

Closed Guilll4um closed 4 years ago

Guilll4um commented 4 years ago

image

maybe it's coz of the new recipe of mesecon one ?

KaylebJay commented 4 years ago

I should have aliased them to the mesecons one. https://github.com/KaylebJay/tunnelers-bugz/issues/30

Guilll4um commented 4 years ago

why you do that just after i precise to keep them coz of different behavior ?

image

Guilll4um commented 4 years ago

keep them was the reason of adding a mescon to the recipe of the mesecones ones : S

Guilll4um commented 4 years ago

i was using them find as the best soluce for my door and for security without any bug since i'm playing

KaylebJay commented 4 years ago

Good point. We should re-add them but we need Hume2's opinion since he wanted them removed.

Guilll4um commented 4 years ago

ok :)

fluxionary commented 4 years ago

It sounds like you plan to re-add them, but I just wanted to butt in and say that aliasing the xdecor ones to the mesecons ones isn't a good idea, as mesecons nodes need to execute logic during on_construct. You'd need to use an LBM to convert them, and players would be left w/ unknown nodes in their inventory.

Guilll4um commented 4 years ago

And it's not the same behavior with iron door !

and aliasing them you are making security breach on iron door driven by xdecor pressure plate doing that, for example, all guys could enter the private parts of my base >_<

Guilll4um commented 4 years ago

i'm sure making protected iron door with pressure plate best way is : iron door + xdecor pressure plate (that might use onwer metadata of iron door i think ) ...

coz with mescon it need player detector + mescon dectector + lua controller or logic gates ... that i think are more server demanding :) ... and in little space you cant use that without destroying all and reworking all.. i spend sevral hours to study the best way to put that doors and pressure plate in underground narrow corridors , close to each other, and asking other player to test the behavior according to the ownership.

in a word if you delete these pressure plate i got to rework all my base , i will have to destroy all and redo all :) ... it's not important but it's to show that xdecor pressure plate are very usefull when you want to do sharp things :) that are very different of wot you can do with mescon ones :)

Hume2 commented 4 years ago

suggestion:

xdecor stone pressure plate -> steel pressure plate xdecor wooden pressure plate -> bronze pressure plate

Guilll4um commented 4 years ago

yes could be good .. with aliasing them of course ! to repair all unknow nodes of them in the world : p and keeping same behavior than before

fluxionary commented 4 years ago

Just for reference, after experimenting w/ unifying them on BlS, I decided it was too complicated. This was my solution: https://github.com/BlockySurvival/bls_custom/commit/36f10554e2efd188e815bf7ffeff3eed2431ccf5#diff-3f1bdbf4ec3f54b2665d89474895625dR631-R668

Guilll4um commented 4 years ago

nice i love the changed recipe i do just before, adding mescon wire to the mesecon one to show they dont got the same behavior at all :)

Guilll4um commented 4 years ago

as far as i'm conserned , i 'm waiting a choice to start playing again with my full base :) i cant access to my base and i dont want to detroy all doors if nothing change :)

KaylebJay commented 4 years ago

WAAAAAAAT ... you can minetest.clear_craft? that's SOOOOO awesome!!

@Guilll4um I will be back to minetest tomorrow (holidays). So sorry for the delay! :S

KaylebJay commented 4 years ago

Hume2's suggestion is what I will implement. If anyone wants to make a pull request, https://github.com/KaylebJay/xdecor is what we use. A minetest.register_alias(olditem, newitem) will be needed to convert the old nodes (metadata would be the same, just a naming/(texture maybe?) change.

Guilll4um commented 4 years ago

it's ok @KaylebJay i finally decided to open just one door to access my drawers room :)

if you're asking if somone can implement that for you i'm ready ... coz drawers are finished (testing) ... even if i'm noob at those stuff :)

KaylebJay commented 4 years ago

Go for it, @Guilll4um :) I'm about to leave on a day trip so I won't be able to review/merge it until tonight. Great to hear that the drawers update is finished!!! :))

Guilll4um commented 4 years ago
        local minp = {x = pos.x - 2, y = pos.y - 1, z = pos.z - 2}
        local maxp = {x = pos.x + 2, y = pos.y + 1, z = pos.z + 2}

here the famous 2 nodes that make xdecor pressure plate open doors around

image i think the guy put 2 nodes so you can make symmetrical things :)

Guilll4um commented 4 years ago

but this can be improve activating only door that are put just in the middle (not at any other side of the same node) and facing the prerssure plate

Guilll4um commented 4 years ago

for betterr understanding with this picture we can :

wot do you think about that ? ... and it's less node to check ! (currently all these nodes are checked ) i think the yellow case is the most used case and this will not break doors openning on the server

image

KaylebJay commented 4 years ago

That's a good idea, Guill.

Guilll4um commented 4 years ago

i'm always on the pressure plate ! it's almost done

i'm preventing doors claping when we stay on the pressure plate :)

KaylebJay commented 4 years ago

https://github.com/KaylebJay/xdecor/pull/2

KaylebJay commented 4 years ago

Fixed by Guill4um - thanks!