search

KaymeKaydex / go-vshard-router

go vshard-router implementation for tarantool
MIT License
21 stars 3 forks source link

A suspicious condition in 'if' operator #38

Closed nurzhan-saktaganov closed 3 months ago

nurzhan-saktaganov commented 3 months ago

In the function "DiscoveryAllBuckets" we have a suspicious condition in the 'if' operator:

https://github.com/KaymeKaydex/go-vshard-router/blob/84c49a6fdfd472916879a9e6cef22c60df380139/discovery.go#L210

However, nextFrom always has a non-nil value. I guess, this function should be rechecked.

nurzhan-saktaganov commented 3 months ago

PR to resolve this issue #45