KaymeKaydex / go-vshard-router

go vshard-router implementation for tarantool
MIT License
21 stars 3 forks source link

Add tnt test for RouterCallImpl #56

Closed nurzhan-saktaganov closed 2 months ago

nurzhan-saktaganov commented 3 months ago
codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.39%. Comparing base (6de86ab) to head (72902d9). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #56 +/- ## ======================================= Coverage 32.39% 32.39% ======================================= Files 10 10 Lines 673 673 ======================================= Hits 218 218 Misses 439 439 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

KaymeKaydex commented 3 months ago

@osperelygin check it please

KaymeKaydex commented 2 months ago

one of the problems that we missed is the lack of grant inside storage

box.once('access:v1', function()
    box.schema.user.grant('guest', 'super')
end)
KaymeKaydex commented 2 months ago

and lets add export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES for MacOS users test safety caused by http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html

nurzhan-saktaganov commented 2 months ago

one of the problems that we missed is the lack of grant inside storage

box.once('access:v1', function()
  box.schema.user.grant('guest', 'super')
end)

Done

nurzhan-saktaganov commented 2 months ago

and lets add export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES for MacOS users test safety caused by http://sealiesoftware.com/blog/archive/2017/6/5/Objective-C_and_fork_in_macOS_1013.html

Done