search

KazDragon / paradice9

Telnet Chatter in C++14
Other
8 stars 2 forks source link

Implemented Z-order cache in container. #185

Closed KazDragon closed 8 years ago

KazDragon commented 8 years ago

In this way, the Z-order is not re-computed unless components have been added or removed from the container since it was last drawn.

Closes #184

Review on Reviewable

KazDragon commented 8 years ago

Note: unlike the idea specified in the problem description, sorting the components at insertion time does not work: it requires that anything subclassing container performs this, which can't be guaranteed, and it also because the actual order of insertion is important for certain layouts (e.g. compass layout). Therefore, caching the Z-order seemed the best workaround.

KazDragon commented 8 years ago

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io