KazDragon / terminalpp

A C++ library for interacting with ANSI terminal windows.
MIT License
75 stars 10 forks source link

Improved virtual key control code output #248

Closed KazDragon closed 3 years ago

KazDragon commented 3 years ago

Previously, whitespace characters such as newline and tab characters printed out literal newline and tab characters. Now they print out encoded forms (e.g. '\n' and '\t'). This allows for better handling during tests.


This change is Reviewable

KazDragon commented 3 years ago

CMakeLists.txt, line 112 at r1 (raw file):


# For producing automatically-generated documentation, we use Doxygen.
find_package(Doxygen)

This appears to be a rebase error.

KazDragon commented 3 years ago

CMakeSettings.json, line 6 at r1 (raw file):

      "name": "x64-Debug",
      "generator": "Ninja",
      "configurationType": "Debug",

This file should be excluded from git.

KazDragon commented 3 years ago

test/virtual_key_test.cpp, line 92 at r1 (raw file):


static virtual_key_test_data const virtual_key_strings[] = {
    // A virtual key should just output the wrapper and the \x00 sequence.

Comment has drifted out of truth.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.04%) to 95.438% when pulling 935afc3e994c0d300bfd73cd598cd6d182f47ae9 on virtual-key-control-code-output into 4cc00e9f2c279e7310ca8357e7e3fa71a23bc495 on master.