KazanExpress / vue-simple-suggest

Feature-rich autocomplete component for Vue.js
https://kazanexpress.github.io/vue-simple-suggest/
MIT License
461 stars 74 forks source link

Warning "Please provide `display-attribute`" is shown initially #277

Open schnetzi opened 4 years ago

schnetzi commented 4 years ago

I'm submitting a ...

What is the current behavior?

Currently a warning is shown when v-model is missing which says [vue-simple-suggest]: Please, providedisplay-attributeas a key or a dotted path for a property from your object.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

I created a codesandbox where you can see that behaviour. https://codesandbox.io/s/simple-suggest-warning-28hht?fontsize=14&hidenavigation=1&theme=dark

If you go to components/SimpleSuggest.vue and remove line 4 (v-model="inputString") you will see a warning popping up in your console. Refresh the browser and it is still there. Adding it again and refreshing the browser will solve the issue.

What is the expected behavior?

I have two different ideas:

  1. The warning message will be something more related to the problem.
  2. No warning message as it is not necessarily needed.

How are you importing Vue-simple-suggest?

What is the motivation / use case for changing the behavior?

Let people find the problems for warnings more easily. Keep warnings from appearing if there is no need for them.

Please tell us about your environment:

kaskar2008 commented 4 years ago

Hello, @schnetzi We have recognized this issue as a bug and will attempt to solve it ASAP.

goshku commented 4 years ago

What happened with that case? :)

kaskar2008 commented 4 years ago

@gstamosbg COVID has displaced our priorities :( Looking forward to fix all the issues tho.

vencho-mdp commented 2 years ago

Any updates on this?