search

Kazetsukai / onetech

Automated Crafting Guide for One Hour One Life
MIT License
31 stars 24 forks source link

i18n support #143

Open naveed-ahmad opened 5 years ago

naveed-ahmad commented 5 years ago

Released Android app based on this repo and got some request for adding Japanese translation. Here are the results.

screenshot_20181230_033339 screenshot_20181230_033419

English version: screenshot_20181230_033828 screenshot_20181230_033846

I'm not sure if you would want to add i18n support or not, let me now and I can send the PR :)

naveed-ahmad commented 5 years ago

Used google translator, and I'm not sure if translations are correct :)

Wrote some ruby script that prepare a file with object names, then used google translate for translating into Japanese. Another script then parsed the translation and filled sqlite db ( I'm using sqlite db instead of json files )

All this can be automate.

ryanb commented 5 years ago

The Android app looks pretty cool, out of curiosity, did you use just the processing script of this repo or the front-end Vue side too?

If we are just using Google Translate then I don't think it's worth adding i18n to this repo. Some browsers (such as Chrome) will automatically offer to translate a page which doesn't match their main language. Others you can get a browser extension to do translations on the fly.

If we did manual translation (perhaps in coordination with the Translation forum) it may be worth it, but that would be difficult to keep up to date as new objects are added.

naveed-ahmad commented 5 years ago

@ryanb both, but frontend is very much customised now. Initially I had added lots of stuff in process script as well but you were too fast in releasing new stuff. Now, abandoned my fork of processing script and wrote few ruby script which will parse json files from created using onetech processing and populate sqlite db.

For frontend I have used f7 components: http://framework7.io

App is using JS based sqlite client which is very slow, next release will use native sqlite which I'm hopping will improve the speed.

ryanb commented 5 years ago

Good to know, glad you found the repo useful.

Closing this since I think most people can translate through the browser. If I receive more requests for this I will reopen.

ryanb commented 5 years ago

Reopening this since it may be possible to get translations from the mobile devs. I think it would be more worthwhile if we have custom translations.