search

KazuAlex / openpollslack

Open source poll slack app
69 stars 20 forks source link

Anoymous and Limit flags don't work #3

Closed unknowndomain closed 5 years ago

unknowndomain commented 5 years ago

Using this and the example from the readme.md

/openpoll anonymous limit “What is best?” “Cats” “Dogs”

These flags don't work you can still see who voted at both ends, and you can vote multiple times

KazuAlex commented 5 years ago

Hello @unknowndomain Thanks for reporting this issue.

This is probably due to the mac replacements quotes... It's working great with correct quotation mark ( " ) ... use this for the moment and i'll investigate on it soon.

unknowndomain commented 5 years ago

So the solution might be here: https://github.com/KazuAlex/openpollslack/blob/706e97278e3bebd5bd2b7ac94a4fc6da34589b58/index.js#L145

To either do a string replace to replace these quotes, or to change the pattern to include the other two types of quote marks?

KazuAlex commented 5 years ago

I know exactly where is the problem (outside of macOS). This is my shitty code :D

KazuAlex commented 5 years ago

Hi @unknowndomain I've fixed that. You can check the commit ( 13f1d53c741e563ca35f5ce8de8e09f2f97f10c8 ) :)

unknowndomain commented 5 years ago

Perfect!