search

Kcaden20 / critical-code-cookbook

This is the official repository for the Critical Code Cookbook Website
2 stars 0 forks source link

reducing content displayed on contribution thumbnails #13

Closed xinemata closed 2 years ago

xinemata commented 2 years ago

After populating the contributions page with content, the level of detail displayed under individual thumbnail starts to feel a little overwhelming to me. I wonder if we should simplify it by only displaying Title, Author Name, and Keywords. I'm also wondering if it's possible to add "#" in front of keywords.

Here's an example:

Screen Shot 2022-06-22 at 12 56 09 AM
Kcaden20 commented 2 years ago

@xinemata see issue: https://github.com/Kcaden20/critical-code-cookbook/issues/8

Kcaden20 commented 2 years ago

@xinemata closed #8 and going to use this issue post as the main spot. Adding details from the previous issue below.

Going to add a limit on the amount of tags that show on the Contribution Hub (probably to two) to avoid stuff like this. Potentially also limiting the character count. Also changing the styling to look more like the tags on the contribution page (i.e with a #)

Screen Shot 2022-06-21 at 5 11 02 PM
xinemata commented 2 years ago

Oh yes! Sorry to have missed that and thanks for consolidating.

For the number of tags that shows up on thumbnails: can we keep it at 3 since that's the number we've asked from the contributors?

Kcaden20 commented 2 years ago

I've limited the categories to three as well as shortened the length of the byline. I think getting rid of it would make all the entries too same looking. It's now only 100 characters instead of 140. Screen Shot 2022-06-24 at 1 40 34 PM

xinemata commented 2 years ago

That makes sense to me. Would it be possible to align all the <h5> so that the entry title share the same height position?

xinemata commented 2 years ago

Another issue that came up for me is when the byline would start with an image caption of the entry. Would it be possible to exclude image captions from the byline?

Screen Shot 2022-06-26 at 1 33 03 PM
Kcaden20 commented 2 years ago

That makes sense to me. Would it be possible to align all the <h5> so that the entry title share the same height position?

Align in which way? on the same line? I don't think this is possible given how long some of the category tags are for some of the entries. The only other surefire way to make sure that they're all the same height would be to make each category tag one line.

Kcaden20 commented 2 years ago

Figcaptions Removed! Screen Shot 2022-06-27 at 12 37 19 PM

xinemata commented 2 years ago

It seems like the thumbnails paddings have been adjusted in ways that make this look better to my eyes right now. I'd consider this issue closed.