search

Kcaden20 / critical-code-cookbook

This is the official repository for the Critical Code Cookbook Website
2 stars 0 forks source link

Visual hover state for links in body texts #19

Closed xinemata closed 2 years ago

xinemata commented 2 years ago

For accessibility purposes, can we add a visual hover state for links inside the body texts?

I believe visual hover states have been implemented everywhere else on the site, so we should be all good on those fronts.

Screen Shot 2022-06-22 at 11 53 41 PM
Kcaden20 commented 2 years ago

Visual Hover State has been added. Since the in-body text already has an underline, this visual state inverts the colors to highlight it—This also distinguishes it from nav related hover states and references the hover state of other linked items within the body.

EDIT: Updated to include a little padding on the sides Screen Shot 2022-06-23 at 2 32 08 PM

xinemata commented 2 years ago

Thanks. It looks good to me. Can you also apply it to links under <ol>, <ul>, and <figcaption>?

If you take a look at this entry, you can see that the visual effect doesn't apply to links under those tags.

xinemata commented 2 years ago

Found another one – <h4> under How to code human bodies for devouring and mutual enlightenment doesn't have a visual hover state.

Screen Shot 2022-06-23 at 5 57 36 PM
xinemata commented 2 years ago

Also links under subpages. See this example.

Screen Shot 2022-06-23 at 6 35 50 PM
Kcaden20 commented 2 years ago

Alright, I was being too specific with my css selector. It's broader now to encompass any a tag within the main tag

Kcaden20 commented 2 years ago

@xinemata This should be properly implemented now but will leave open in case something else comes up

xinemata commented 2 years ago

Didn't find any other missing spot during the second round of editing. Closing the issue.