search

Kcaden20 / critical-code-cookbook

This is the official repository for the Critical Code Cookbook Website
2 stars 0 forks source link

pink overlay on image hover #37

Closed xinemata closed 2 years ago

xinemata commented 2 years ago

By the way! I remember seeing a faded pink overlay when the cursor hovers over images a short while ago and I don't see that anymore. Did you change your mind on it @Kcaden20?

Kcaden20 commented 2 years ago

I'd been messing around with a hover style for the figures in general and wasn't happy with that specific one. I think I've settled on one that mimics the hyperlink style.

Screen Shot 2022-06-30 at 6 07 28 PM Screen Shot 2022-06-30 at 6 07 36 PM
Kcaden20 commented 2 years ago

Nvm—Realized this doesn't work because images go to the corner.

Kcaden20 commented 2 years ago

Images will just subtly fade out:

Screen Shot 2022-06-30 at 6 16 22 PM Screen Shot 2022-06-30 at 6 16 15 PM
xinemata commented 2 years ago

That looks good to me! Thanks for trying it out.

On Jul 1, 2022, at 12:17 AM, Kcaden20 @.***> wrote:

 Assigned #37 to @xinemata.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.

xinemata commented 2 years ago

Sorry I've just caught this now, but this is possibly not working with images that are set as "portrait" or "square". For example take a look at the Love Poem image on this entry: https://criticalcode.recipes/contributions/recipe-for-erotic-event-listeners

Kcaden20 commented 2 years ago

@xinemata just tested—this is being caused by the alt-text. I just removed it and it worked properly. I've readded it for the time being though I'm unsure of how it's affecting it.

xinemata commented 2 years ago

This has been resolved. Closing the issue.