search

Kdyby / Console

Symfony Console integration for Kdyby components
https://packagist.org/packages/kdyby/console
Other
52 stars 54 forks source link

Bugfix: fixed the test for PR 45 (no issue nr) #49

Closed foglcz closed 7 years ago

foglcz commented 8 years ago

As I'm working on issue # 48, I noticed that original PR in tests had a wrong assumption. Original bugfix tried to fix two commands with same argument names - which is allright.

BUT nette-di-autowire-by-default policy means, that you'd in fact declare services into args only when they cannot be auto resolved. This updates the test accoardingly.

Note that autowire - resolve - problems will be part of separate PR, which will fix # 48 . Thus, this is a separate PR, which just updates the testcase for the PR 45

fprochazka commented 8 years ago

I have no idea what that is testing and why is it in "input errors" test case :-/

foglcz commented 8 years ago

This is testing https://github.com/Kdyby/Console/pull/45 , and I put it into input errors because it seemed like a proper place..

fprochazka commented 7 years ago

Thanks, but I still don't understand what this is doing.