search

Kdyby / Console

Symfony Console integration for Kdyby components
https://packagist.org/packages/kdyby/console
Other
52 stars 54 forks source link

Allow symfony/console 3.0 #55

Closed enumag closed 8 years ago

enumag commented 8 years ago

Unfortunately symfony/console 3.0 contains a BC break - the header of renderException method now contains type hints which means a separate version of kdyby/console would be needed for symfony 3.x.

In my opinion its better to remove this method from Kdyby. The condition is used when calling this method anyway so the only change is when calling it manually.

fprochazka commented 8 years ago

@enumag I also ran into this and I agree that removing it seems like a better option. I'm just can't remember why I haven't done it already, since I've tried this too. Do you know of any other possible problems?

enumag commented 8 years ago

@fprochazka None that I'm aware of.

fprochazka commented 8 years ago

Imho we need to add a 2.* travis build with this.

enumag commented 8 years ago

@fprochazka Agreed but I think I'll leave that to you. I don't have that much experience with Travis configuration yet.

fprochazka commented 8 years ago

I was about to do it anyway, just saying :)

fprochazka commented 8 years ago

I've remembered, I have to first solve compatibility of kdyby/events with symfony/event-dispatcher:~3.0 so I can allow here symfony/event-dispatcher:~2.3|~3.0 ... otherwise, the symfony/console:3.* does not install.

fprochazka commented 8 years ago

Hmm, It installed, but it's weird. I'll dig around for a bit.

I see now, symfony 3.0 is for 5.5 only.

enumag commented 8 years ago

It is not. Components from symfony 2.8 and 3.0 are (mostly) compatible with each other. Besides it's not really relevant - kdyby/console does not depend on kdyby/events or symfony/event-dispatcher.

fprochazka commented 8 years ago

@enumag Thank you :)