search

Kdyby / Console

Symfony Console integration for Kdyby components
https://packagist.org/packages/kdyby/console
Other
52 stars 54 forks source link

Catching \Throwable leads to problems when try to render it. #61

Closed kratkyzobak closed 8 years ago

kratkyzobak commented 8 years ago

Symfony\Console\Application::renderException(\Exception $o, OutputInterface $output) is not compatibile with catching \Throwable.

Modified Kdyby\Console\Application::handleException to use own (very simple) render method (and Tracy to store error in log, as usual).

fprochazka commented 8 years ago

Thank you!

trejjam commented 7 years ago

I found that Symfony solve this decorating by Symfony\Component\Debug\Exception\FatalThrowableError so they can use same renderException for render.
Would you like change it this way?

fprochazka commented 7 years ago

@Trejjam yes, I think that's a good idea! I will do that :)

fprochazka commented 7 years ago

https://github.com/Kdyby/Console/commit/7e9eef0e18d7fc9fc0cedb594412b68ed63ca9bb

trejjam commented 7 years ago

Wow! Thank you

One small question, could you create new tag for this repo?

fprochazka commented 7 years ago

Yes :)