search

Kdyby / Console

Symfony Console integration for Kdyby components
https://packagist.org/packages/kdyby/console
Other
52 stars 54 forks source link

nette 3.0 compatibility #68

Closed MartkCz closed 6 years ago

MartkCz commented 7 years ago

getConfig hasn't any parameters.

enumag commented 6 years ago

@MartkCz Does this work with Nette 2.4 as well?

MartkCz commented 6 years ago

Yes, works. In current version, defaults parameters aren't combined with config values and config values aren't checked (source: https://api.nette.org/2.4/source-DI.CompilerExtension.php.html#55-81).

foxycode commented 6 years ago

@enumag Will this be merged?

enumag commented 6 years ago

Merged, thanks.