search

Kdyby / Console

Symfony Console integration for Kdyby components
https://packagist.org/packages/kdyby/console
Other
52 stars 54 forks source link

Fixed CI #82

Closed foxycode closed 5 years ago

foxycode commented 5 years ago

It was little bit harder than I expected. I needed to add strict_types and return type hints. Not all checks could be fixed, I can't add return type hints where parent class don't have them for example. Hope it is ok this way.

foxycode commented 5 years ago

@enumag Is it ok this way?

enumag commented 5 years ago

Fine by me.

@VBoss WDYT? Anything else before we can make a new release?

foxycode commented 5 years ago

@enumag @VBoss I see Symfony 4.* tests failed, but they are in allowed failures. Was it ok before or not?

enumag commented 5 years ago

@foxycode Other SF4 tests are passing. I'm guessing these are builds against dev symfony, which means 4.3 in this case. Since 4.3 will be released soon, I think we need to have this fixed.

foxycode commented 5 years ago

@enumag I don't know why it is failing and I believe it's not related to my changes. You can probably merge this.

Spamercz commented 5 years ago

Failing tests are related to changes in events in symfony 4.3-dev, more here https://github.com/Kdyby/Events/pull/120#discussion_r271074516 There is some big BC break in arguments for events, I didnt looked into that closely but this should be fixed in another PR, because that BC break will probably persist to our Kdyby implementations too.

Spamercz commented 5 years ago

Anyway PR is ok we can make release.

enumag commented 5 years ago

Ah so the BC break will be solved in Kdyby/Events and doesn't directly affect Kdyby/Console? In that case we can make the new release.