search

Kdyby / CsobPaymentGateway

[DEPRECATED] Client library for ČSOB Payment Gateway eAPI 1.5+
Other
13 stars 3 forks source link

Payment phpDoc #18

Closed honzalilak closed 7 years ago

honzalilak commented 8 years ago

Hi,

method Payment::getOriginalPayId() will return NULL in some cases, however the phpDoc annotation says it returns string only. This may happen because setting the property origPayId is not required. Shouldnt the annotation be |NULL for properties that are not required to be set as well as for their getters?

I can make PR but I would like to confirm that you are open to that.

fprochazka commented 8 years ago

If there is a state, where the object allows the value to be NULL (and it's not a bug), then surely it should be in the phpdoc.