search

Kdyby / DoctrineCache

Doctrine 2 Cache integration into Nette Framework
https://packagist.org/packages/kdyby/doctrine-cache
Other
10 stars 21 forks source link

Add alias for apcu cache #11

Closed jiripudil closed 8 years ago

jiripudil commented 8 years ago

doctrine/cache added ApcuCache driver in 1.6. I thought it would be nice to have a config shortcut for the driver.

enumag commented 8 years ago

Add a test please. https://github.com/Kdyby/DoctrineCache/blob/master/tests/KdybyTests/DoctrineCache/Extension.phpt#L48

jiripudil commented 8 years ago

Oh. It seems that doctrine/cache 1.6.0 which added the apcu driver requires PHP >= 5.5, so 5.4 builds fail. What do you suggest? Should I split the test case and skip apcu test on 5.4? (And maybe separate memcache test for PHP 7 build while I'm at it?)

enumag commented 8 years ago

Hmm. I don't know how exactly skipping works in Nette/Tester so I'm not sure about the best solution.

ping @fprochazka

fprochazka commented 8 years ago

@jiripudil you can create Extensions.php55.phpt

<?php

/**
 * @testcase
 * @phpversion 5.5
 */

and move it there

fprochazka commented 8 years ago

I'll fix the build and you can rebase on it then :)

jiripudil commented 8 years ago

Rebased :)

fprochazka commented 8 years ago

@jiripudil you're too fast :P I'm not done yet

jiripudil commented 8 years ago

:lol:

enumag commented 8 years ago

@jiripudil Don't forget to squash. :-)

fprochazka commented 8 years ago

@jiripudil not that I think about it more, having a separate file is not neccesary :) See the testFunctionalityMemcache

fprochazka commented 8 years ago

great :+1: