search

Kdyby / DoctrineCache

Doctrine 2 Cache integration into Nette Framework
https://packagist.org/packages/kdyby/doctrine-cache
Other
10 stars 21 forks source link

Support caching "empty" values #13

Closed Andrewsville closed 8 years ago

Andrewsville commented 8 years ago

Support for caching "empty" values, mainly empty arrays.

enumag commented 8 years ago

Could you add a test? I believe it is very important in this case.

fprochazka commented 8 years ago

Very nice catch! But I'm gonna need a test case for this. I might have some time at the weekend, so if you won't do it, hopefuly I'll have the time.

Andrewsville commented 8 years ago

Well, my knowledge of Nette tester is exactly zero but I'll try to make a simple test.

fprochazka commented 8 years ago

@Andrewsville tester is easy, if you could create the test, that would be awesome! :)

enumag commented 8 years ago

ping @Andrewsville

fprochazka commented 8 years ago

I've added the test and merged. Thanks!

Please test it if possible and report back.

enumag commented 8 years ago

@fprochazka I think we should include this bugfix to older branches as well (for usage with Nette 2.2). Not that I need it personally though.

fprochazka commented 8 years ago

True