search

Kdyby / DoctrineCache

Doctrine 2 Cache integration into Nette Framework
https://packagist.org/packages/kdyby/doctrine-cache
Other
10 stars 21 forks source link

Make Nette 3.0 compatible #16

Closed TomasVotruba closed 7 years ago

enumag commented 7 years ago

Need to update composer and travis.

TomasVotruba commented 7 years ago

This only hot fix PR.

It would actually mean lot of Kdyby packages refactoring, dropping deprecated packages, bumping to PHP 7 etc. I'll let that to @fprochazka

Majkl578 commented 7 years ago

The problem with this is that it is not possible to keep the package backward compatible, due to the nature of the changes and the fact that parameter types are invariant (to be contravariant in PHP 7.2),

TomasVotruba commented 7 years ago

Yes, this requires bump to PHP 7.1.

enumag commented 7 years ago

@Majkl578

(to be contravariant in PHP 7.2)

I don't understand. Seems like you're talking about something new in PHP 7.2. Can you give me a link to the RFC you're hinting?

Majkl578 commented 7 years ago

https://wiki.php.net/rfc/parameter-no-type-variance