Add nette/reflection to dependencies

Kdyby / Events

Events for Nette Framework

https://packagist.org/packages/kdyby/events

Other

58 stars 60 forks source link

Add nette/reflection to dependencies #104

Closed enumag closed 7 years ago

enumag commented 8 years ago

EventsExtension uses nette/reflection classes but the dependency is missing in composer.json. Today one of my builds failed because of that: https://travis-ci.org/Zenify/DoctrineFixtures/jobs/164474624

This is just a hotfix. Better fix would be to remove usage of nette/reflection.

coveralls commented 8 years ago

Coverage remained the same at 77.395% when pulling 32695fdd4f7e236ac9ae23a329274873401f41ca on enumag:patch-2 into 81716e12fa8dc5136fbd7c5071134ca401a4bda9 on Kdyby:master.

fprochazka commented 7 years ago

You're right, we should remove the dependency.

fprochazka commented 7 years ago

Thank you for the PR.