search

Kdyby / Events

Events for Nette Framework
https://packagist.org/packages/kdyby/events
Other
57 stars 60 forks source link

Full Symfony EventDispatcher's support (with EventSubscriberInterface) #92

Closed hranicka closed 7 years ago

hranicka commented 8 years ago

Maybe this refs to #89

Currently, only Doctrine Events are fully supported.

They're supported Symfony Events too, but only partially. Event dispatching only.

My problem:

I want to use Symfony Console + Monolog + Symfony Monolog Bridge. It's realized via this subscriber.

But I cannot register this subscriber (eg. with tags in config). It's not a Doctrine EventSubscriber.

I've made another extension of Kdyby/Events extension: https://github.com/etten/symfony-events

Should I create a PR to this repo for full built-in support of Symfony Events?

I think a lot of changes will be needed - the Symfony EventSubscriber requires static method and carries information about event name, handler method and priority.

enumag commented 8 years ago

@hranicka What about https://github.com/Symnedi/EventDispatcher?

fprochazka commented 8 years ago

I'm gonna have to think about this more, but I'm not sure full support of symfony/event-dispatcher is a good way. See #97

fprochazka commented 7 years ago

I've decided - I wanna drastically simplify this package, so adding full support for symfony dispatcher is not doable, sorrry.