Kdyby / Facebook

[DEPRECATED] Use https://github.com/thephpleague/oauth2-facebook instead
Other
42 stars 36 forks source link

Undefined index: appsecret_proof #36

Closed MartinMystikJonas closed 9 years ago

MartinMystikJonas commented 9 years ago

Not sure what changed. We start getting this notice after upgrade:

PHP Notice: Undefined index: appsecret_proof in /var/www/flowlist/libs/kdyby/facebook/src/Kdyby/Facebook/Api/CurlClient.php:217

Problem occures in code from my PR #22. But I'm not sure why this error show now.

So the question is: should I fix my code (add isset check) or is this unintentional side effect of some other change and should be fixed elsewhere?

fprochazka commented 9 years ago

Yeah, the conditions should be a bit smarter.

MartinMystikJonas commented 9 years ago

Fix in PR #37